Don't drop cached packages when only removing packages (RhBug:2237883) #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to have a easier workflow for making package caching exceptions for some commands and also to match the `keepcache` behavior with the original dnf in this matter, the cached files are now removed only when `keepcache` option is turned off at the moment.
|
The current PR is creating an exception for the |
j-mracek
reviewed
Sep 15, 2023
j-mracek
suggested changes
Sep 20, 2023
When the `keepcache` option is turned off, the packages downloaded during a previous command should still be preserved until a subsequent successful transaction that involves inbound actions such as installation or upgrading. This assumption is based on the idea that these packages were downloaded for this purpose. As a result, temporary packages are retained even across transactions that do not involve any inbound actions. This feature is also valuable in cases where a previous transaction downloaded a substantial amount of data but did not complete correctly. In such instances, we want to rectify the system state by removing problematic packages without losing our cached data. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2237883
jan-kolarik
force-pushed
the
jkolarik/dont-drop-cached-packages-on-remove
branch
from
d6895e1
to
5fdd3fe
Compare
jan-kolarik
force-pushed
the
jkolarik/dont-drop-cached-packages-on-remove
branch
from
5fdd3fe
to
b4dbb55
Compare
|
LGTM |
j-mracek
approved these changes
Oct 2, 2023
|
@jan-kolarik Thank you very much for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have a easier workflow for making package caching exceptions for some commands and also to match the
keepcachebehavior with the original dnf in this matter, the cached files are now removed only whenkeepcacheoption is turned off at the moment.We don't want to remove the stored packages cache after running the
removecommand transaction, therefore we override thekeepcacheoption to true. This is useful for use cases when the previous transaction downloaded a large amount of data, but didn't finished correctly. Then we'd like to fix the system state by removing some problematic package. We don't want to lose our cached data in this case.CI tests: rpm-software-management/ci-dnf-stack#1381
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2237883